[Webkit-unassigned] [Bug 122015] [ATK] Expose aria-invalid as a text attribute (not object attribute)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 1 15:30:34 PDT 2013


--- Comment #16 from Mario Sanchez Prada <mario at webkit.org>  2013-10-01 15:29:29 PST ---
(In reply to comment #15)
> (From update of attachment 213096 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=213096&action=review
> >> Source/WebCore/accessibility/AccessibilityObject.cpp:1348
> >> +    DEFINE_STATIC_LOCAL(const AtomicString, invalidStatusGrammar, ("grammar", AtomicString::ConstructFromLiteral));
> > 
> > we probably don't need statics for these (as per recent discussions on webkit-dev) - we can probably switch these to just ASCIILiterals inline
> Do you mean also changing the return value of this method from AtomicString& to String?

Hmm... or maybe you mean using ASCIILiterals just for "grammar" and "spelling" (for the comparison only), and leave the "true" and "false" ones as statically defined AtomicStrings (thus keeping the AtomicString& return type) ?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list