[Webkit-unassigned] [Bug 122170] FTL: split overflow checks into non-overflow arithmetic and an additional call to the overflow intrinsic check.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122170


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #213117|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #9 from Filip Pizlo <fpizlo at apple.com>  2013-10-01 14:09:21 PST ---
(From update of attachment 213117)
View in context: https://bugs.webkit.org/attachment.cgi?id=213117&action=review

Looks great!

> Source/JavaScriptCore/ChangeLog:36
> +LBB0_1:                                 ## %OSR exit continuation for @24<Int32>
> +                                        ## =>This Inner Loop Header: Depth=1
> +    movl  %ecx, %esi
> +    incl  %esi
> +    jo  LBB0_4

I would indent this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.