[Webkit-unassigned] [Bug 122015] [ATK] Expose aria-invalid as a text attribute (not object attribute)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122015





--- Comment #15 from Mario Sanchez Prada <mario at webkit.org>  2013-10-01 13:46:41 PST ---
(From update of attachment 213096)
View in context: https://bugs.webkit.org/attachment.cgi?id=213096&action=review

>> Source/WebCore/accessibility/AccessibilityObject.cpp:1348
>> +    DEFINE_STATIC_LOCAL(const AtomicString, invalidStatusGrammar, ("grammar", AtomicString::ConstructFromLiteral));
> 
> we probably don't need statics for these (as per recent discussions on webkit-dev) - we can probably switch these to just ASCIILiterals inline

Do you mean also changing the return value of this method from AtomicString& to String?

>> Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:303
>> +    if (!invalidStatus.isEmpty() && invalidStatus != "false") {
> 
> invalidStatus should never be empty now right?

That's very true. I'll change that

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.