[Webkit-unassigned] [Bug 90611] contenteditable justify commands applied to next paragraph as well
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 1 10:30:17 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=90611
--- Comment #18 from Santosh Mahto <santosh.ma at samsung.com> 2013-10-01 10:29:13 PST ---
>
> >> Source/WebCore/editing/ApplyStyleCommand.cpp:274
> >> + VisiblePosition beyondEnd((visibleEnd.deepEquivalent().deprecatedEditingOffset() || visibleEnd == paragraphStart) ? endOfParagraph(visibleEnd).next() : visibleEnd);
> >
> > Can you do this without using anything with “deprecated” in its name?
I changed the code.
>
> This change doesn't make much sense. What does the deprecated editing offset being non-zero to do with visibleEnd == paragraphStart?
I changed the code its now visibleEnd != visibleStart.
ApplyBlockElementCommand::doApply() : already has same adjustment for paragraph break. Same adjustment is done here.
I updated the testcase align-in-expected.txt as it was failing for this change.
I found on http://trac.webkit.org/changeset/50433 this test is for crash test.
and expected txt has not much significance.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list