[Webkit-unassigned] [Bug 122148] [ATK] Expose ARIA Busy state

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 1 08:48:36 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=122148





--- Comment #8 from Samuel White <samuel_white at apple.com>  2013-10-01 08:47:31 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> >   PASS findByAccessibleTitleSubstring(root, 'InnerButton') != null is false
> >   Got notification on iframe.
> >  +FAIL findByAccessibleTitleSubstring(root, 'InnerButton') != null should be true. Was false.
> >  +Got notification on iframe.
> >  +PASS findByAccessibleTitleSubstring(root, 'InnerButton') != null is true
> >  +Got notification on iframe.
> >   PASS findByAccessibleTitleSubstring(root, 'InnerButton') != null is true
> >   PASS gotIframeNotification is true
> >   PASS successfullyParsed is true
> > 
> > 
> > 
> > This is a diff output while I'm running accessibility/loading-iframe-sends-notification.html
> > with the changes related to exposing aria-busy notification
> 
> Hrm... I think what it's happening here is that in the following piece of code in that test...
> 
>     [...]
>     // Initially, the iframe should not be loaded, so we shouldn't be able to find this button.
>     shouldBeFalse("findByAccessibleTitleSubstring(root, 'InnerButton') != null");
> 
>     window.accessibilityController.addNotificationListener(function (target, notification) {
>         // Ignore this notification if it's not on the iframe.
>         if (target.description.indexOf("InnerFrame") == -1)
>             return;
> 
>         debug("Got notification on iframe.");
>         gotIframeNotification = true;
> 
>         // Check that the button within the iframe is now reachable from the root.
>         shouldBeTrue("findByAccessibleTitleSubstring(root, 'InnerButton') != null");
>     });
>     [...]
> 
> 
> ... the notification listener is now being called more often than before, as now you are also emitting a signal/notification when the busy state changes (AXElementBusyChanged), not simply when the layout is completed (AXLayoutComplete), which I think is the only case that was being captured before in that listener. Adding a "debug('Notification received: ' + notification);" line in that test could be useful to check whether that theory is true.

Agreed. We should be seeing one AXLoadComplete and one AXLayoutComplete notification, not sure about the third one. Adding a debug as suggested to dump the notification type should shed some light on what is going wrong here.

> 
> If that's the case, maybe we could update this test so that listener early returns when the notification received is not the expected one (AXLayoutComplete, I suppose), but still it's a mystery to me why this problem is not happening in the Mac in the first place, since I guess they should be getting the additional notification there as well.
> 
> Chris, Samuel, any comment on this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list