[Webkit-unassigned] [Bug 120998] [Win] Compile errors when enabling DFG JIT.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120998


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #214863|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #28 from Brent Fulgham <bfulgham at webkit.org>  2013-10-30 10:11:16 PST ---
(From update of attachment 214863)
View in context: https://bugs.webkit.org/attachment.cgi?id=214863&action=review

Thanks for resolving those issues. This looks fine to me.

r=me

> Source/WTF/wtf/ThreadingOnce.h:68
> +    bool m_calledOnce;

It's a shame that Windows doesn't provide this functionality. A future improvement might be to base this on whatever Windows uses to handle "do this once" functionality. Perhaps that is just a mutex and a flag, but when we move to 64-bit, we will have access to more modern OS features, which might be helpful here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.