[Webkit-unassigned] [Bug 123441] [GStreamer] gst-vaapi 1.3 support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123441





--- Comment #6 from Philippe Normand <pnormand at igalia.com>  2013-10-30 09:50:38 PST ---
(From update of attachment 215377)
View in context: https://bugs.webkit.org/attachment.cgi?id=215377&action=review

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:355
>> +#if GST_CHECK_VERSION(1, 3, 0)
> 
> Why 1.3.0? All this should be supported since GStreamer 1.2.0.

But there's no release of gst-vaapi with that support yet and they moved all their code-checking to 1.3 already... So I thought I'd do the same :)

>> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:64
>>  #define WEBKIT_VIDEO_SINK_PAD_CAPS GST_FEATURED_CAPS GST_VIDEO_CAPS_MAKE(GST_CAPS_FORMAT)
> 
> This now means that you also have video/x-raw,format=NV12 here (i.e. without the caps feature). However without the GL texture upload meta NV12 is not supported by the sink.

Hmm, right... Ok I'll revise the patch. Thanks for looking!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.