[Webkit-unassigned] [Bug 123153] [ATK] Avoid explicit traversal of text controls and the render tree in AtkText implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123153


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #215501|review?                     |review+
               Flag|                            |




--- Comment #8 from chris fleizach <cfleizach at apple.com>  2013-10-30 09:13:40 PST ---
(From update of attachment 215501)
View in context: https://bugs.webkit.org/attachment.cgi?id=215501&action=review

minor comment. I think it's OK to collapse those for now. Mac may eventually want to use the emitsObjectReplacement and I think we'd also want the same children behavior GTK wants

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:657
> +        if (m_renderer->node()) {

you can probably do a if (Node* node = m_renderer->node()) and then get rid of the next if check. 
I know sometimes those results might be different but I'm pretty sure AXrenderObject's node() method just does m_renderer->node() anyway

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.