[Webkit-unassigned] [Bug 123111] Upstream ENABLE(REMOTE_INSPECTOR) and enable on iOS and Mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123111


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joepeck at webkit.org




--- Comment #8 from Joseph Pecoraro <joepeck at webkit.org>  2013-10-25 13:58:33 PST ---
(In reply to comment #7)
> (From update of attachment 214782 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214782&action=review
> 
> >> Source/WebKit/mac/WebInspector/remote/WebInspectorRelayDefinitions.h:38
> >> +#define WIRServiceDisabledNotification          "com.apple.webinspectord.disabled"
> > 
> > These could be const NSString * instead. Also there isn't any reason for the symbol to keep the "WIR" prefix, it could differ even if the string content needs to keep "WIR".
> 
> These are used by XPC/notify APIs which take C strings, so I just kept them C String constants. Would there be an advantage to making them NSStrings? Just seems like more work unless they are actually used as NSStrings.
> 
> I agree that there is no need to keep the defines WIR prefixed. The consistency, and prefix makes it obvious to me that these are shared constants. If I changed them, I'd like to change them to "RWI", but of course the values need to stay "WIR" for backwards compatibility.

You mentioned this could be "const char*" types. I'll address this in a follow-up.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.