[Webkit-unassigned] [Bug 123260] Replace 0 timeouts g_timeout_add() by g_idle_add()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123260





--- Comment #12 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-10-25 01:05:14 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > (From update of attachment 215146 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=215146&action=review
> > 
> > > Source/WebCore/ChangeLog:11
> > > +        Patch by Bastien Nocera <hadess at hadess.net>
> > 
> > Why not adding the author to the changelog header so that commit-queue will credit him correctly?
> > 
> > > Source/WebKit/gtk/webkit/webkitwebview.cpp:5276
> > > -        g_timeout_add(1, cleanupTemporarilyCachedSubresources, g_list_copy(subResources));
> > > +        g_idle_add_full(G_PRIORITY_DEFAULT, cleanupTemporarilyCachedSubresources, g_list_copy(subResources), 0);
> > 
> > This is not correct, I don't know why but this was not a 0 timeout.
> 
> I think this should be fixed in another patch.

Well, I'm not sure it's wrong, it seems it was added intentionally, I still don't understand it, though see:

https://bugs.webkit.org/show_bug.cgi?id=108960#c24

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.