[Webkit-unassigned] [Bug 123205] Adding mock class to test RTCDataChannelHandler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123205





--- Comment #5 from Thiago de Barros Lacerda <thiago.lacerda at openbossa.org>  2013-10-23 10:39:28 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (From update of attachment 214955 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=214955&action=review
> > > 
> > > > Source/WebCore/ChangeLog:11
> > > > +        No new tests needed.
> > > 
> > > I would say "Existing tests updated" instead.
> > > 
> > > > Source/WebCore/ChangeLog:16
> > > > +        * platform/mock/RTCDataChannelHandlerMock.cpp: Copied from Source/WebCore/platform/mock/RTCNotifiersMock.cpp.
> > > > +        * platform/mock/RTCDataChannelHandlerMock.h: Copied from Source/WebCore/platform/mock/RTCNotifiersMock.h.
> > > 
> > > Are these "Copied from" comments correct?
> > 
> > Git thinks that I copied them, maybe because of its similarity check. But I didn't not copy. Should I remove them?
> > > 
> 
>   I would remove the comments because they are incorrect.
> 
> > > > Source/WebCore/platform/mock/RTCDataChannelHandlerMock.h:51
> > > > +    String label() OVERRIDE { return m_label; }
> > > > +    bool ordered() OVERRIDE { return m_ordered; }
> > > > +    unsigned short maxRetransmitTime() OVERRIDE { return m_maxRetransmitTime; }
> > > > +    unsigned short maxRetransmits() OVERRIDE { return m_maxRetransmits; }
> > > > +    String protocol() OVERRIDE { return m_protocol; }
> > > > +    bool negotiated() OVERRIDE { return m_negotiated; }
> > > > +    unsigned short id() OVERRIDE { return m_id; }
> > > > +    unsigned long bufferedAmount() OVERRIDE { return 0; }
> > > 
> > > These should all be virtual.
> > 
> > Why? The class is final, so no class can use it as superclass and override its methods.
> > 
> 
>   Oops :-O

By looking at the webkit source, I could notice that they put the virtual keyword anyway, maybe is it a style? Should I add virtual?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.