[Webkit-unassigned] [Bug 123205] Adding mock class to test RTCDataChannelHandler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123205


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #214955|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #2 from Eric Carlson <eric.carlson at apple.com>  2013-10-23 10:18:53 PST ---
(From update of attachment 214955)
View in context: https://bugs.webkit.org/attachment.cgi?id=214955&action=review

> Source/WebCore/ChangeLog:11
> +        No new tests needed.

I would say "Existing tests updated" instead.

> Source/WebCore/ChangeLog:16
> +        * platform/mock/RTCDataChannelHandlerMock.cpp: Copied from Source/WebCore/platform/mock/RTCNotifiersMock.cpp.
> +        * platform/mock/RTCDataChannelHandlerMock.h: Copied from Source/WebCore/platform/mock/RTCNotifiersMock.h.

Are these "Copied from" comments correct?

> Source/WebCore/platform/mock/RTCDataChannelHandlerMock.h:51
> +    String label() OVERRIDE { return m_label; }
> +    bool ordered() OVERRIDE { return m_ordered; }
> +    unsigned short maxRetransmitTime() OVERRIDE { return m_maxRetransmitTime; }
> +    unsigned short maxRetransmits() OVERRIDE { return m_maxRetransmits; }
> +    String protocol() OVERRIDE { return m_protocol; }
> +    bool negotiated() OVERRIDE { return m_negotiated; }
> +    unsigned short id() OVERRIDE { return m_id; }
> +    unsigned long bufferedAmount() OVERRIDE { return 0; }

These should all be virtual.

> Source/WebCore/platform/mock/RTCDataChannelHandlerMock.h:66
> +    String m_label;
> +    bool m_ordered;
> +    unsigned short m_maxRetransmitTime;
> +    unsigned short m_maxRetransmits;
> +    String m_protocol;
> +    bool m_negotiated;
> +    unsigned short m_id;

Nit: it may be slightly more space efficient to have the "short" and "bool" members last.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.