[Webkit-unassigned] [Bug 122748] [contenteditable] Content after non-editable element disappears when merging lines using backspace

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122748





--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2013-10-22 17:53:09 PST ---
(From update of attachment 214771)
View in context: https://bugs.webkit.org/attachment.cgi?id=214771&action=review

> Source/WebCore/ChangeLog:9
> +        contain contenteditable=false element then after merging

Nit: contain*s*. Also need a comma after "element"

> Source/WebCore/ChangeLog:10
> +        non-editable and afterwards content are lost and only content

I don't get what you mean here. Perhaps something along this line?
"then content after the non-editable element will be removed while the content before the element will be merged with the first paragraph"

> Source/WebCore/ChangeLog:12
> +        happens becasue endOfParagraphToMove calculation in merging function doesnot

Nit: either "doesn't" or "does not".

> LayoutTests/editing/deleting/merge-paragraph-contatining-noneditable-expected.txt:2
> + Expected behavior is on hitting backspace all three word (First,second and third) should be visible and merged at the end of first line.

Why do we have a space at the beginning of this line?
Also, we need a space between "First," and "second" and "first" should not be capitalized.

> LayoutTests/editing/deleting/merge-paragraph-contatining-noneditable-expected.txt:8
> +|   "You should not lose "second Third" from second line when both paragraphs will be merged."

Why is only Third capitalized?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.