[Webkit-unassigned] [Bug 123145] [WK2][GTK] enable-media-stream Setting

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123145





--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-10-22 03:50:00 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 214828 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=214828&action=review
> > 
> > Thanks for the patch. API looks good to me, except for the mediastream -> media_stream change. WebKit2 cross-platform changes require a wk2 owner approval. Units tests are missing too, please add a test for get/set to the TestWebKitSettings test.
> > 
> 
> Cool, thanks for the review! I added a test, did you see it?

Oops, sorry, I missed it, I reviewed it too fast.

> Anyway, I'll update the patch.

Thanks

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.