[Webkit-unassigned] [Bug 122097] ASSERTION FAILED: !style->propertyIsImportant(propertyID) in WebCore::setTextDecorationProperty

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122097





--- Comment #11 from Santosh Mahto <santosh.ma at samsung.com>  2013-10-19 01:03:45 PST ---
(In reply to comment #9)
> (From update of attachment 214482 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214482&action=review
> 
> > Source/WebCore/editing/ApplyStyleCommand.cpp:1016
> > -    if ((node->renderer()->isRenderBlockFlow() || node->childNodeCount()) && node->isHTMLElement()) {
> > +    if ((node->renderer()->isRenderBlockFlow() || node->childNodeCount() || node->renderer()->isReplaced()) && node->isHTMLElement()) {
> 
> All replaced elements?  So we do this for img, input, etc...?  That doesn't sound right.
> We also need tests for that.

You are probably right.., considering the domain of bug it not right to change the behavior for all replaced element. I am planning to stick to just iframe check.

> > Source/WebCore/editing/EditingStyle.cpp:-1411
> >          // text-decoration: none is redundant since it does not remove any text decorations.
> > -        ASSERT(!style->propertyIsImportant(propertyID));
> 
> I think the point of this code is that if text-decoration was specified with !important then we don't want to be overriding it with a new text decoration.

The point is new text decoration at this point will  be empty. So we remove the property. it does not matter its important or not. 

     if (newTextDecoration->length()) 
    {
    }
    else {  // newTextDecoration->length() == 0

        ASSERT(!style->propertyIsImportant(propertyID));  
        style->removeProperty(propertyID);
    }


> > LayoutTests/editing/execCommand/remove-format-textdecoration-in-iframe.html:7
> > +    <iframe onload="{ document.designMode='on';
> > +                      document.execCommand('selectall');
> > +                      document.execCommand('RemoveFormat'); }"></iframe>
> 
> Can we move this function out of the attribute and put it in the script element below?
Yes I will do.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.