[Webkit-unassigned] [Bug 123038] New: Refactor LineBreaker::nextSegmentBreak, add BreakingContext that holds all it state

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123038

           Summary: Refactor LineBreaker::nextSegmentBreak, add
                    BreakingContext that holds all it state
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: zoltan at webkit.org
            Blocks: 121261


I tried the follow Levi's logic on Blink's nextSegmentBreak refactoring (https://chromiumcodereview.appspot.com/25054004). I mostly did the same changes, but the code is too diverged at this point to just apply that patch on our trunk.
The patch introduces BreakingContext as a separate class. I added new methods for each condition. I also removed the goto-s from the code.  All the new methods are inline in order to avoid introducing any performance regression. The change makes the code so much cleaner and understandable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.