[Webkit-unassigned] [Bug 122787] JavaScriptCore tests should run on Windows
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 16 10:53:37 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=122787
Brent Fulgham <bfulgham at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #214231|review? |review-
Flag| |
--- Comment #8 from Brent Fulgham <bfulgham at webkit.org> 2013-10-16 10:52:23 PST ---
(From update of attachment 214231)
View in context: https://bugs.webkit.org/attachment.cgi?id=214231&action=review
The overall idea here is great, but your change would cause catastrophic breaking of our internal build process so I must reject this patch.
> Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.submit.sln:44
> +Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "WTF", "..\..\WTF\WTF.vcxproj\WTF.vcxproj", "{8EF73779-BED3-45BB-816D-9FF58399AFA5}"
You can't do this. WTF.submit.sln and JavaScriptCore.submit.sln are isolated from each-other for a reason.
What you COULD do, is make sure there is a JavaScriptCore.sln that looks exactly like this file, and have build-jsc use that file (instead of JavaScriptCore.submit.sln).
> Source/WTF/WTF.vcxproj/WTF.submit.sln:-2
> -Microsoft Visual Studio Solution File, Format Version 11.00
Why are you removing this file? It's critical.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list