[Webkit-unassigned] [Bug 122832] [GStreamer] use a smart pointer for ::setStreamVolumeElement()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 16 08:10:17 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=122832





--- Comment #7 from Philippe Normand <pnormand at igalia.com>  2013-10-16 08:09:01 PST ---
(In reply to comment #6)
> (From update of attachment 214264 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214264&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        Use a smart pointer all the way from call site to member variable storage.
> 
> Why?

Oh well I thought it'd simply be cleaner but I can't find other reasons and there's no ref leak in the current code.

So I think I'll end up not doing this change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list