[Webkit-unassigned] [Bug 122889] [EFL] accessibility/plugin.html passes incorrectly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 16 05:25:56 PDT 2013


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #214353|review?                     |review-
               Flag|                            |

--- Comment #4 from Mario Sanchez Prada <mario at webkit.org>  2013-10-16 05:24:41 PST ---
(From update of attachment 214353)
I've just quickly checked for uses of test.swf in the Layout tests directory and found that is used in two more places other than accessibility:

$ git grep "resources/test.swf"
accessibility/plugin.html:       <embed src="resources/test.swf" type="application/x-shockwave-flash">
fast/loader/sandboxed-plugin-crash.html:<iframe src="resources/test.swf" sandbox="allow-same-origin allow-forms allow-scripts"></iframe><br>
fast/replaced/border-radius-clip.html:<embed src="resources/test.swf" style="border:3px solid black; background-color: lime; -webkit-border-radius: 32px; margin-bottom:-32px"
fast/replaced/embed-display-none.html:  <embed style="display:none" src="resources/test.swf"

Additionally, I've also found that all the three different instances of test.swf are actually the same file, duplicated in three different locations:

$ md5sum platform/mac/accessibility/resources/test.swf fast/loader/resources/test.swf fast/replaced/resources/test.swf
140bd629879234796a2334c066a3b9e1  platform/mac/accessibility/resources/test.swf
140bd629879234796a2334c066a3b9e1  fast/loader/resources/test.swf
140bd629879234796a2334c066a3b9e1  fast/replaced/resources/test.swf

So, I think that instead of moving it from platform/mac/accessibility/resources into accessibility/resources, it would be better to put it in LayoutTests/resources/ and update the relative paths in those four tests.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list