[Webkit-unassigned] [Bug 122800] New: When there are no more stylesheets schedule the recalc async

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 14 18:03:27 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=122800

           Summary: When there are no more stylesheets schedule the recalc
                    async
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Keywords: BlinkMergeCandidate
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: hyatt at apple.com, koivisto at iki.fi,
                    simon.fraser at apple.com, benjamin at webkit.org,
                    akling at apple.com


Merge https://chromium.googlesource.com/chromium/blink/+/33c8b55d6d6ed5bf362074532a835903bcd9453b
or come up with a better fix:

Document::didRemoveAllPendingStylesheet gets called whenever the
pending stylesheet counter goes to zero. This can happen many times
in a document if it's inserting inline stylesheets dynamically which
then causes many recalcStyle(Force) to happen.

This patch switches didRemoveAllPendingStylesheet to instead schedule
an async recalc style. This prevents the "waterfall of recalc styles"
you can see in apps that append many <style> elements while they're
loading.

I also removed code that scheduled a relayout when adding or removing
stylesheets since it doesn't appear needed or make sense to do this
outside the normal recalc style flow. In addition making this change
appears to fix the fast/regions/ writing mode tests that were broken
by r157174 where ojan and I fixed writing modes for lazy attach.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list