[Webkit-unassigned] [Bug 122716] Broken text rendering in some cases.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 13 06:05:46 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=122716





--- Comment #3 from peavo at outlook.com  2013-10-13 06:04:33 PST ---
(In reply to comment #2)
> (From update of attachment 214086 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=214086&action=review
> 
> This needs a test case. It should be easy to make one as a ref test. See tests with -expected.html under LayoutTests/fast/text/ for example.
> 
> r- because lack of test case or even information how to reproduce the bug.
> 
> > Source/WebCore/ChangeLog:3
> > +        Broken text rendering in some cases.
> 
> What cases? The bug description doesn't say either.
> 

Sorry for the short description :) I added an url where it can be reproduced, at least when running WinCairo. 

> > Source/WebCore/rendering/InlineTextBox.cpp:551
> > -    TextPaintStyle selectionPaintStyle = computeTextSelectionPaintStyle(textPaintStyle, renderer(), lineStyle, paintInfo, paintSelectedTextOnly, paintSelectedTextSeparately, selectionShadow);
> > -
> > +    TextPaintStyle selectionPaintStyle = computeTextSelectionPaintStyle(textPaintStyle, renderer(), lineStyle, paintInfo, haveSelection, paintSelectedTextOnly, paintSelectedTextSeparately, selectionShadow);
> 
> Instead of adding an extra boolean parameter it would be better to just not call computeTextSelectionPaintStyle if haveSelection is false.

OK, but isn't there some initialization at the beginning of computeTextSelectionPaintStyle that needs to be done even if haveSelection is false?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list