[Webkit-unassigned] [Bug 122716] Broken text rendering in some cases.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122716


Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #214086|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Antti Koivisto <koivisto at iki.fi>  2013-10-13 02:04:25 PST ---
(From update of attachment 214086)
View in context: https://bugs.webkit.org/attachment.cgi?id=214086&action=review

This needs a test case. It should be easy to make one as a ref test. See tests with -expected.html under LayoutTests/fast/text/ for example.

r- because lack of test case or even information how to reproduce the bug.

> Source/WebCore/ChangeLog:3
> +        Broken text rendering in some cases.

What cases? The bug description doesn't say either.

> Source/WebCore/rendering/InlineTextBox.cpp:551
> -    TextPaintStyle selectionPaintStyle = computeTextSelectionPaintStyle(textPaintStyle, renderer(), lineStyle, paintInfo, paintSelectedTextOnly, paintSelectedTextSeparately, selectionShadow);
> -
> +    TextPaintStyle selectionPaintStyle = computeTextSelectionPaintStyle(textPaintStyle, renderer(), lineStyle, paintInfo, haveSelection, paintSelectedTextOnly, paintSelectedTextSeparately, selectionShadow);

Instead of adding an extra boolean parameter it would be better to just not call computeTextSelectionPaintStyle if haveSelection is false.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.