[Webkit-unassigned] [Bug 122694] Factor line box code from RenderText to a class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 12 10:24:45 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=122694


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #214057|review?                     |review+
               Flag|                            |




--- Comment #2 from Andreas Kling <akling at apple.com>  2013-10-12 10:23:33 PST ---
(From update of attachment 214057)
View in context: https://bugs.webkit.org/attachment.cgi?id=214057&action=review

> Source/WebCore/rendering/RenderTextLineBoxes.cpp:43
> +        m_first = m_last = textBox;

We should do this on two lines.

> Source/WebCore/rendering/RenderTextLineBoxes.cpp:59
> +        m_first = 0;

nullptr

> Source/WebCore/rendering/RenderTextLineBoxes.cpp:114
> +    m_first = m_last = 0;

nullptr
Also, we should do this on two lines.

> Source/WebCore/rendering/RenderTextLineBoxes.cpp:117
> +InlineTextBox* RenderTextLineBoxes::findNext(int offset, int& pos) const

Crappy name: pos.

> Source/WebCore/rendering/RenderTextLineBoxes.cpp:120
> +        return 0;

nullptr

> Source/WebCore/rendering/RenderTextLineBoxes.cpp:129
> +    pos = (offset > currentOffset ? current->len() : current->len() - (currentOffset - offset) );

Extra space before last ')'

> Source/WebCore/rendering/RenderTextLineBoxes.cpp:143
> +    const InlineTextBox* prev = 0;

nullptr

> Source/WebCore/rendering/RenderTextLineBoxes.h:45
> +    void extract(InlineTextBox*);
> +    void attach(InlineTextBox*);
> +    void remove(InlineTextBox*);

Seems like these should really take references. Maybe in a later patch?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list