[Webkit-unassigned] [Bug 122627] DFG: Add JIT support for LogicalNot(String/StringIdent)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122627





--- Comment #5 from Filip Pizlo <fpizlo at apple.com>  2013-10-11 10:52:38 PST ---
(From update of attachment 214001)
View in context: https://bugs.webkit.org/attachment.cgi?id=214001&action=review

Can you also add a test?  Best to add one in LayoutTests/js, and use the dfgShouldBe function to drive the test. There should be examples in that directory that do it. This will automatically run the test long enough to tier-up into the DFG.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:4184
> +    m_jit.load32(MacroAssembler::Address(strGPR, JSString::offsetOfLength()), lenGPR);

Why not use compare32() that takes an Address and a TrustedImm32?  It will give you the same functionality with just one instruction on x86 and I think just two on arm.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.