[Webkit-unassigned] [Bug 122448] [ATK] Support compilation of EFL/GTK without accessibility
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 9 15:00:35 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=122448
chris fleizach <cfleizach at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cfleizach at apple.com
--- Comment #7 from chris fleizach <cfleizach at apple.com> 2013-10-09 14:59:25 PST ---
(In reply to comment #6)
> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:1434
> > > > +namespace WTR {
> > >
> > > Is there code like this already inside AccessibilityUIElement.cpp?
> > Yes there is, you mean it could be reused ?.
> > Sounds good, I will check this.
>
> It could be reused as well as I guess bits from AccessibilityUIController.cpp
> Line #if !PLATFORM(MAC) && !PLATFORM(GTK) && !PLATFORM(EFL) in AccessibilityUIElement.cpp
> can be changed to
> #if (!PLATFORM(MAC) && !PLATFORM(GTK) && !PLATFORM(EFL)) || !HAVE(ACCESSIBILITY)
>
> but then respective mac files should have #if HAVE(ACCESSIBILITY) added, otherwise when accessibility is disabled, redefinition conflicts will happen.
I think we should re-use these. I don't want to have to maintain two long lists of unsupported functions when adding to DRT
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list