[Webkit-unassigned] [Bug 122467] Modify WTF and JavascriptCore makefiles for 64bit build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 7 15:10:56 PDT 2013


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #213618|review?                     |review+, commit-queue-
               Flag|                            |

--- Comment #2 from Brent Fulgham <bfulgham at webkit.org>  2013-10-07 15:09:48 PST ---
(From update of attachment 213618)
View in context: https://bugs.webkit.org/attachment.cgi?id=213618&action=review

r=me with one suggestion before you land.

> Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.make:36
> +    set Path=%PATH%;$(SRCROOT)\%ProgramFilesAAS%

It seems like this %PATH% will contain the 32-bit path from line 12/14 above. Should we use a separate value here? Or maybe hold onto the original PATH (pre-changing in 12/14) with a different name, like "set OrigPath=%PATH%", then here do "Set Path=%OrigPath%;$(SRCROOT)...etc."

> Source/WTF/WTF.vcxproj/WTF.make:26
> +    set Path=%PATH%;$(SRCROOT)\%ProgramFilesAAS%

Ditto regarding path from above. Might want to retain original path in a separate variable, then use it here so we don't get the 32-bit path before our 64-bit stuff.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list