[Webkit-unassigned] [Bug 117631] [GTK] Provide search functionality to MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117631





--- Comment #26 from Andres Gomez Garcia <agomez at igalia.com>  2013-10-07 09:30:17 PST ---
(In reply to comment #24)
> (From update of attachment 208268 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=208268&action=review
> 
> > Tools/MiniBrowser/gtk/BrowserSearchBar.c:50
> > +    if (failedSearch)
> > +        gtk_style_context_add_provider(gtk_widget_get_style_context(searchBar->entry), GTK_STYLE_PROVIDER(searchBar->cssProvider), GTK_STYLE_PROVIDER_PRIORITY_APPLICATION);
> > +    else
> > +        gtk_style_context_remove_provider(gtk_widget_get_style_context(searchBar->entry), GTK_STYLE_PROVIDER(searchBar->cssProvider));
> 
> For some reason this is not working for me. I'm not a theming expert, but I think a better approach would be to use always a custom css provider and load it with different data, instead of having two providers and add/remove them. I think you can use gtk_style_context_reset_widgets after calling gtk_css_provider_load_from_data.
...

AFAIK, it should work either way.

In any case, I've rebased the patch and removed the styling bits. Let's leave it for a future patch ...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.