[Webkit-unassigned] [Bug 120769] [CSS Regions] Selection focusNode set to the "region" block, instead of the "source" block

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120769





--- Comment #13 from Radu Stavila <stavila at adobe.com>  2013-10-07 09:24:32 PST ---
(From update of attachment 213405)
View in context: https://bugs.webkit.org/attachment.cgi?id=213405&action=review

> Source/WebCore/rendering/RenderRegion.cpp:65
> +    LayoutPoint newPoint(0, point.y());

No point in initialising newPoint's y with point.y() since you're going to override it by calling newPoint.setY(...) in all cases.

> Source/WebCore/rendering/RenderRegion.cpp:66
> +    if (point.y() > m_flowThreadPortionRect.height()) // hitting bottom margin, padding or border.

Does this work well when the last region is overflowing downwards?

> Source/WebCore/rendering/RenderRegion.cpp:68
> +    else if (point.y() < 0) // hitting top margin, padding or border.

Same question for regions overflowing upwards (for instance by setting a negative top-margin on the flowed content).

> Source/WebCore/rendering/RenderRegion.cpp:73
> +    if (m_flowThread->firstChild()) // checking for empty region blocks.

I think you should perform the firstChild() check before computing newPoint because you could end up computing it for nothing (since you're not using it if firstChild() == 0).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.