[Webkit-unassigned] [Bug 122440] JavaScriptCore fails to build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 7 09:00:41 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=122440


Mark Lam <mark.lam at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #213570|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Mark Lam <mark.lam at apple.com>  2013-10-07 08:59:33 PST ---
(From update of attachment 213570)
View in context: https://bugs.webkit.org/attachment.cgi?id=213570&action=review

> Source/JavaScriptCore/debugger/DebuggerCallFrame.cpp:186
> +    ASSERT(!callFrame->codeBlock());
> +    ASSERT(!callFrame->codeBlock());

These asserts are meaningless without the line and column checks.  But you are right that the line and column checks are not valid.  Please remove the 2 asserts completely.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list