[Webkit-unassigned] [Bug 122322] MediaStreamTrack can't be FINAL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 4 17:44:41 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=122322


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #213343|review?                     |review+
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2013-10-04 17:43:34 PST ---
(From update of attachment 213343)
How did this even compile?

Can any of the virtual functions in MediaStreamTrack be FINAL? If the entire class isn’t FINAL, it then becomes helpful to mark the functions themselves FINAL if there is no need to override them.

r=me but I suggest adding some FINAL to any functions we don’t need to override.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list