[Webkit-unassigned] [Bug 122363] FTL: Optimize IsString(@2<String>) -> JSConst(true) + Phantom()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122363





--- Comment #2 from Darin Adler <darin at apple.com>  2013-10-04 17:28:44 PST ---
(From update of attachment 213424)
View in context: https://bugs.webkit.org/attachment.cgi?id=213424&action=review

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:894
> +        case IsString: {
> +            if (node->child1().useKind() == StringUse) {
> +                m_insertionSet.insertNode(m_indexInBlock, SpecNone, Phantom, node->codeOrigin,
> +                    Edge(node->child1().node(), StringUse));
> +                node->convertToConstant(1);
> +                break;
> +            }
> +        }

While I am not qualified to review this, I do have two small style comments: We should break rather than falling through at the end of this case. Also, there is no need for the outer braces around the if statement, so please remove them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.