[Webkit-unassigned] [Bug 122170] FTL: split overflow checks into non-overflow arithmetic and an additional call to the overflow intrinsic check.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122170





--- Comment #11 from Filip Pizlo <fpizlo at apple.com>  2013-10-01 14:39:54 PST ---
(In reply to comment #10)
> Indent the commit message ? In what way ?

The ChangeLog messages should have at least eight-space indent except for the header ("2013-10-01  Nadav Rotem  <nrotem at apple.com>").  So this part of your patch:

+LBB0_1:                                 ## %OSR exit continuation for @24<Int32>
+                                        ## =>This Inner Loop Header: Depth=1
+    movl  %ecx, %esi
+    incl  %esi
+    jo  LBB0_4

Should be:

+        LBB0_1:                                 ## %OSR exit continuation for @24<Int32>
+                                                ## =>This Inner Loop Header: Depth=1
+            movl  %ecx, %esi
+            incl  %esi
+            jo  LBB0_4

We have some scripts that try to parse changelog's, so sticking to the format is usually a good idea.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.