[Webkit-unassigned] [Bug 122170] FTL: split overflow checks into non-overflow arithmetic and an additional call to the overflow intrinsic check.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 1 13:18:15 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=122170





--- Comment #5 from Nadav Rotem <nrotem at apple.com>  2013-10-01 13:17:11 PST ---
Yes. It works with Mul, Add and Inc.   I am sure that we are missing some patterns but we can fix them as we go. 

This:

function foo() {
  var sum = 1
  while (sum < 100000000)
    sum *= 10
}

Becomes this:

LBB0_1:                                       ## =>This Inner Loop Header: Depth=1
    imull    $10, %eax, %ecx
    jo    LBB0_7

## BB#2:                                ## %OSR exit continuation for @11<Int32>
                                              ##   in Loop: Header=BB0_1 Depth=1
    testl    %ecx, %ecx
    je    LBB0_3
LBB0_4:                                 ## %ArithMul continuation
                                             ##   in Loop: Header=BB0_1 Depth=1
    cmpl    $100000000, %ecx        ## imm = 0x5F5E100
    movl    %ecx, %eax
    jl    LBB0_1
    jmp    LBB0_5

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list