[Webkit-unassigned] [Bug 122062] Web Inspector: content view in back/forward list multiple times won't restore earlier positions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122062


Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #212954|review?                     |review+, commit-queue+
               Flag|                            |




--- Comment #11 from Timothy Hatcher <timothy at apple.com>  2013-10-01 10:42:56 PST ---
(From update of attachment 212954)
View in context: https://bugs.webkit.org/attachment.cgi?id=212954&action=review

> Source/WebInspectorUI/ChangeLog:60
> +        Need a short description (OOPS!).
> +        Need the bug URL (OOPS!).

OOPS.

> Source/WebInspectorUI/UserInterface/BackForwardEntry.js:37
> +WebInspector.BackForwardEntry.prototype = {
> +    constructor: WebInspector.BackForwardEntry,

Even if it isn't useful now, this should still inherit from WebInspector.Object.

> Source/WebInspectorUI/UserInterface/ResourceSidebarPanel.js:264
> +        var cookie = { lineNumber: positionToReveal.lineNumber, columnNumber: positionToReveal.columnNumber};

Nit, space after { should be removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.