[Webkit-unassigned] [Bug 122000] [GStreamer] Support "chapter" text tracks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=122000


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #213014|review?                     |review+
               Flag|                            |




--- Comment #5 from Eric Carlson <eric.carlson at apple.com>  2013-10-01 08:08:39 PST ---
(From update of attachment 213014)
View in context: https://bugs.webkit.org/attachment.cgi?id=213014&action=review

> Source/WebCore/platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:36
> +class InbandMetadataTextTrackPrivateGStreamer : public InbandTextTrackPrivate {

Nit: FINAL

> LayoutTests/media/in-band-cues.js:185
> +        for (var i = 1; i < numInBandTracks + 1; ++i) {
> +          compareTracks("video.textTracks[" + (i + 1) + "]", "inbandTrack" + i);
> +        }

Nit: braces aren't necessary here

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.