[Webkit-unassigned] [Bug 122156] New: [Tools] Add the check for use of static_cast on objects in Style Checker

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 1 05:14:31 PDT 2013


           Summary: [Tools] Add the check for use of static_cast on
                    objects in Style Checker
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: r.kasibhatla at samsung.com
                CC: darin at apple.com, sam at webkit.org,
                    gyuyoung.kim at samsung.com, rniwa at webkit.org,
                    akling at apple.com

As part of new changes (added by Kling/Gyuyoung et. all), WebKit is migrating to new syntax of calling toFoo() instead of doing static_cast on Foo objects and more and more classes are being changed to add toFoo helper functions. There should be a way to ensure that the added helpers are actually *used* in the code. Currently, there is no enforcement to use the added toFoo functions nor we exert pressure on the dev to add new toFoo() if required in some new module. We should add this check to style checker and try to *enforce* rigidly the use/addition of toFoo().
For now we can keep the change under *disabled* filter and once all the codebase is changed to use toFoo() we should report a style error if the uploaded patch contains static_cast on any object.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list