[Webkit-unassigned] [Bug 122144] New: Get rid of Node::preDispatchEventHandler and Node::postDispatchEventHandler

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 1 01:06:19 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=122144

           Summary: Get rid of Node::preDispatchEventHandler and
                    Node::postDispatchEventHandler
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML DOM
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rniwa at webkit.org
                CC: sam at webkit.org, koivisto at iki.fi, akling at apple.com


Node::preDispatchEventHandler and Node::postDispatchEventHandler are only implemented by HTMLInputElement and HTMLMediaElement for a couple of events.
There is no reason every single event dispatch has to pay the cost of calling these virtual functions.

Furthermore, preDispatchEventHandlerResult that's passed around from preDispatchEventHandler and postDispatchEventHandler is only used by HTMLInputElement's preDispatchEventHandler and it's always of type ClickHandlingState. Since ClickHandlingState is never subclassed, we don't even need to heap-allocate this object.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list