[Webkit-unassigned] [Bug 124820] check-webkit-style should check member initialization indentation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124820





--- Comment #6 from Peter Gal <galpeter at inf.u-szeged.hu>  2013-11-29 01:15:46 PST ---
(From update of attachment 217932)
View in context: https://bugs.webkit.org/attachment.cgi?id=217932&action=review

>>> Tools/Scripts/webkitpy/style/checkers/cpp.py:1997
>>> +        matched = search(r'(?P<indentation>\s*).*', begin_line)
>> 
>> For this 'matched 'you could use the regex's return value in the if above.
> 
> No it's not the same. The base of the indention can be the previous non blank line. example:
> 
>     myClass()
>         : myInt(0)
>     { }
> 
> The above if you mentioned will match on the second line, but we need the indention of the first line.

Oh.. I missed the second parameter of the search. My bad.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.