[Webkit-unassigned] [Bug 124965] [EFL] glViewport() is set up than the viewSize.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124965


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gyuyoung.kim at samsung.com




--- Comment #7 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2013-11-28 22:34:26 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 218028 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=218028&action=review
> > 
> > > Source/WebKit2/ChangeLog:3
> > > +        [EFL] glViewport() is set up than the viewSize.
> > 
> > I really don't understand what does this title means now. Do you mean that glViewport size is bigger than viewSize ? Anyway, it seems to me that you want to change glViewport size with viewSize, right ?
> > 
> Yes, right. I mean that the glViewport size is bigger than viewSize.
> > > Source/WebKit2/ChangeLog:9
> > > +        Nevertheless, the viewport is translated when being painted, it looks correct.
> > 
> > AFAIK, we should fix something when it is *correct*, not *looks correct*.
> Because the glViewport size bigger than viewSize, unnecessary work was occured.

When we upload a patch, you should mention *why* this patch should be landed or why we need to land this patch. However, your patch description isn't clear for me. Please fix your changelog more clear. It would be good if you get a review from your co-worker before uploading new patch.

FYI, "unnecessary work was occured." => "unnecessary work occurred" is correct, AFAIK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.