[Webkit-unassigned] [Bug 124943] Checkout should own the scm object in Host

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 28 02:37:36 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=124943





--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org>  2013-11-28 02:36:02 PST ---
(From update of attachment 217955)
View in context: https://bugs.webkit.org/attachment.cgi?id=217955&action=review

> Tools/Scripts/webkitpy/common/host.py:82
> +        scm = detector.default_scm(patch_directories)
> +        self._checkout = Checkout(scm)

It seems like Checkout's constructor could simply take patch_directories.
If not, we could do all of this in one line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list