[Webkit-unassigned] [Bug 124868] Implement Render Media Controls for WinCairo

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124868





--- Comment #6 from Brent Fulgham <bfulgham at webkit.org>  2013-11-26 19:13:03 PST ---
(From update of attachment 217840)
View in context: https://bugs.webkit.org/attachment.cgi?id=217840&action=review

I have a few questions about the implementation! Can you take a look and answer?

> Source/WebCore/rendering/RenderMediaControlsWinCairo.cpp:101
> +    // TODO: fix image...

Please provide a bug number for this image fix!

> Source/WebCore/rendering/RenderMediaControlsWinCairo.cpp:108
> +    static Image* mediaSliderThumb = platformResource("mediaSliderThumb");

Why do we have this static function here, but simply declare static inline functions elsewhere? Is this used in a number of places?

> Source/WebCore/rendering/RenderMediaControlsWinCairo.cpp:122
> +    // FIXME: this should be a rounded rect but need to fix GraphicsContextSkia first.

I don't think this comment is useful anymore; we no longer have a Skia-based port.

> Source/WebCore/rendering/RenderMediaControlsWinCairo.cpp:134
> +    // FIXME: Draw multiple ranges if there are multiple buffered ranges.

Bug number!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.