[Webkit-unassigned] [Bug 124879] [EFL] Layout tests need to be rebaselined.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 26 10:18:41 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=124879


Michal Pakula vel Rutka <m.pakula at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.pakula at samsung.com




--- Comment #3 from Michal Pakula vel Rutka <m.pakula at samsung.com>  2013-11-26 10:17:08 PST ---
(In reply to comment #2)
> (From update of attachment 217856 [details])
> Those tests definitely need to be rebaselined. Could you take care of png files as well? Those have been added at r140159 and it seems to be out of date. In addition, r159747 rebaselines more tests (at least for mac), don't we need to update them? Thanks

The rests of tests were updated in r159753 and r159755.

The only test here which needs pixel expectation update is fast/table/border-collapsing/004.html, but the difference is not caused by r159747.
The difference is lack of scrollbar in current output and it is started to happen after r156472, precisely this change: http://trac.webkit.org/changeset/156472/trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp @2547. This affects not only this test but around 300-400 other ones causing identical image failures (lack of scrollbars in pixel expectations). 
I think we should leave old pixel expectation even if it is incorrect, in this and other tests and fix the bug with scrollbars.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list