[Webkit-unassigned] [Bug 124822] ImageBuffer::create should return a unique_ptr instead of OwnPtr.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124822





--- Comment #14 from Brian Burg <burg at cs.washington.edu>  2013-11-25 08:05:05 PST ---
(In reply to comment #13)
> (From update of attachment 217805 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217805&action=review
> 
> > Source/WebCore/platform/graphics/ImageBuffer.h:84
> > +            std::unique_ptr<ImageBuffer> buffer(new ImageBuffer(size, resolutionScale, colorSpace, renderingMode, success));
> 
> It might be better to use std::make_unique here: 
> auto buffer = std::make_unique<ImageBuffer>(size, resolutionScale, colorSpace, renderingMode, success);

Ah, true. Thanks for pointing it out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.