[Webkit-unassigned] [Bug 124822] ImageBuffer::create should return a unique_ptr instead of OwnPtr.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 25 07:47:19 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=124822





--- Comment #13 from Sergio Correia (qrwteyrutiyoup) <sergio.correia at openbossa.org>  2013-11-25 07:45:46 PST ---
(From update of attachment 217805)
View in context: https://bugs.webkit.org/attachment.cgi?id=217805&action=review

> Source/WebCore/platform/graphics/ImageBuffer.h:84
> +            std::unique_ptr<ImageBuffer> buffer(new ImageBuffer(size, resolutionScale, colorSpace, renderingMode, success));

It might be better to use std::make_unique here: 
auto buffer = std::make_unique<ImageBuffer>(size, resolutionScale, colorSpace, renderingMode, success);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list