[Webkit-unassigned] [Bug 85994] [GStreamer] Seeking fails on media content provided by servers not supporting Range requests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85994





--- Comment #65 from Andres Gomez Garcia <agomez at igalia.com>  2013-11-25 04:20:11 PST ---
Thanks a lot for the review!

(In reply to comment #61)
> (From update of attachment 217783 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217783&action=review
> 
> >> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:844
> >>          return;
> > 
> > locker.unlock() before return?
> 
> No, you don't need to explicitly call unlock in this case, because it will be called by the GMutexLocker destructor. It was called before because webKitWebSrcStop takes the lock too.
> 
> > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:945
> > +        locker.unlock();
> 
> Si, this not needed either.
> 
> > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:955
> > +            locker.unlock();
> 
> Ditto.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.