[Webkit-unassigned] [Bug 85994] [GStreamer] Seeking fails on media content provided by servers not supporting Range requests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85994





--- Comment #54 from Philippe Normand <pnormand at igalia.com>  2013-11-24 03:09:54 PST ---
(From update of attachment 217737)
View in context: https://bugs.webkit.org/attachment.cgi?id=217737&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:926
> +        GST_DEBUG_OBJECT(src, "Seek in progress, ignoring response");

I think the locker should be unlocked before returning, no?

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:932
> +        if (200 == response.httpStatusCode()) {

I'm not sure this order of values is used elsewhere in WebKit. Usually we do something() == someConstant and not the opposite.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.