[Webkit-unassigned] [Bug 78735] Several missing/incorrect guards for LOG_DISABLED=0 against Release build (Mac)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78735





--- Comment #1 from Andres Gomez Garcia <agomez at igalia.com>  2013-11-22 08:31:34 PST ---
Created an attachment (id=217686)
 --> (https://bugs.webkit.org/attachment.cgi?id=217686&action=review)
Failing build log in Mac when setting the GCC_PREPROCESSOR_DEFINITION "LOG_DISABLED" to 0

(In reply to comment #0)
> Steps to reproduce:
> 
> 1. Add #define LOG_DISABLED 0 near the top of wtf/Assertions.h (this is behavior that should be supported; see the top of Assertions.h)
...

This is not needed, it can be achieved with:
$ Tools/Scripts/build-webkit GCC_PREPROCESSOR_DEFINITIONS='${inherited} LOG_DISABLED=0'

...
> Causes:
> 
> In WebKit2/Platform/mac/Logging.mac.mm:
> 
> * the implementation of WebKit::initializeLogChannel should be guarded by #if !LOG_DISABLED, but is actually guarded by #ifndef NDEBUG. This will cause build breakage if LOG_DISABLED is manually set to false in wtf/Assertions.h, but WebKit is compiled in release mode.
> 
> In WebCore/Exports/ExportFileGenerator.cpp and WebCore.exp.in:
> 
> * the export of symbol __ZN7WebCore20LogNotYetImplementedE is similarly improperly guarded by #if !defined(NDEBUG), whereas it should be guarded by #if !LOG_DISABLED
...

This is not true anymore since this guards where changing some time ago.

However, compiling with LOG_DISABLED=0 is not workind due to missing dependencies as shown in the attached log file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.