[Webkit-unassigned] [Bug 124703] Remove the stderr_write attribute from StyleProcessorConfiguration

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124703





--- Comment #10 from Peter Gal <galpeter at inf.u-szeged.hu>  2013-11-22 04:49:28 PST ---
(From update of attachment 217660)
View in context: https://bugs.webkit.org/attachment.cgi?id=217660&action=review

> Tools/Scripts/webkitpy/style/checker_unittest.py:580
>      def setUp(self):
> -        self._error_messages = []
> -        """The messages written to _mock_stderr_write() of this class."""
> +        LoggingTestCase.setUp(self)

I don't think you need this setUp (and tearDown) method here, because you are explicitly calling the base class' setUp (/tearDown) method. If you don't implement the methods here it'll be inherited, so that's why there is no need for this methods.

Also calling the base class' method this way is not really good, we should use the super() call for such cases (http://docs.python.org/2/library/functions.html#super).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.