[Webkit-unassigned] [Bug 124579] Use unsigned consistently, and check for invalid casts when calling into SharedBuffer from other code.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 22 03:05:25 PST 2013


--- Comment #35 from László Langó <lango at inf.u-szeged.hu>  2013-11-22 03:03:55 PST ---
(In reply to comment #34)
> (From update of attachment 217544 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217544&action=review
> There are even more threads that need to be pulled :(
> See for example this line in WebCoreResourceHandleAsDelegate.mm:
>     m_handle->client()->willStopBufferingData(m_handle, (const char*)[data bytes], static_cast<int>([data length]));
> willStopBufferingData is the first and only name I grepped for, so probabilistically speaking, there are likely more implicit casts remaining. Please grep WebCore for every function name you changed.

Sorry, I missed the *.mm files. I only grepped in *.cpp and *.h files. :s I will check it twice before the next upload. I didn't expected that this change will affect so many files.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list