[Webkit-unassigned] [Bug 107606] EWS creates 0 byte sized log files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=107606





--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org>  2013-11-21 19:23:04 PST ---
(From update of attachment 217559)
View in context: https://bugs.webkit.org/attachment.cgi?id=217559&action=review

> Tools/ChangeLog:12
> +        Reviewed by NOBODY (OOPS!).

This line should appear before the long description but after the bug url.

> Tools/ChangeLog:15
> +        (QueueEngine.run): Open the log file only if a ScriptError was raised.

Why?

> Tools/ChangeLog:16
> +        (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore.

Why?

> Tools/ChangeLog:17
> +        (QueueEngine._ensure_work_log_closed): Close the logfile.

Why?

> Tools/ChangeLog:19
> +        (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError.

Why?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.